[PATCH] git-bundle: fix pack generation.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Mar 6, 2007, 07:45 UTC
- Message-ID
- <7vejo2stlw.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <45ECEB40.4000907@gmail.com>
The handcrafted built-in rev-list lookalike forgot to mark the trees and blobs contained in the boundary commits uninteresting, resulting in unnecessary objects in the pack.
Signed-off-by: Junio C Hamano <junkio@cox.net> ---
* I'll have this in 'master' tonight. Also I am thinking about changing 'git bundle verify' to spit out heads and prereqs unconditionally, in addition to 'foo.bdl is ok'. Comments?
builtin-bundle.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/builtin-bundle.c b/builtin-bundle.c index d41a413..279b8f8 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -263,6 +263,11 @@ static void show_object(struct object_array_entry *p) write_or_die(1, "\n", 1); } +static void show_edge(struct commit *commit) +{ + ; /* nothing to do */ +} + static int create_bundle(struct bundle_header *header, const char *path, int argc, const char **argv) { @@ -341,6 +346,7 @@ static int create_bundle(struct bundle_header *header, const char *path, dup2(in, 1); close(in); prepare_revision_walk(&revs); + mark_edges_uninteresting(revs.commits, &revs, show_edge); traverse_commit_list(&revs, show_commit, show_object); close(1); while (waitpid(pid, &status, 0) < 0)
-- 1.5.0.3.862.g71037