Re: [PATCH] Show binary file size change in diff --stat

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 28, 2007, 19:41 UTC
Message-ID: <Pine.LNX.4.63.0702282040430.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <200702281842.15147.andyparkins@gmail.com>

Hi,

On Wed, 28 Feb 2007, Andy Parkins wrote:

Show 19 quoted lines

> On Wednesday 2007, February 28, Johannes Schindelin wrote:
> 
> > for added files (and the obvious thing for deleted ones), but with
> > your patch, both added and deleted get
> >
> > 	Bin 123456 bytes
> >
> > which is not so optimal.
> 
> See my corrected patch.  However, while you're interested: how would one 
> tell the difference between 0 bytes and (no file).  I'm thinking of 
> these possibilities:
> 
>  new -> 123456
>  0 -> 123456
>  123456 -> deleted
>  123456 -> 0
> 
> For example - does mmfile_t.ptr set to NULL mean anything?

In non-binary case, we have only plusses or minusses, so you cannot tell either. You have to look into the summary for that.

Ciao, Dscho