Re: [PATCH] Show binary file size change in diff --stat

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 28, 2007, 15:37 UTC
Message-ID: <Pine.LNX.4.63.0702281630430.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <200702281515.10016.andyparkins@gmail.com>

Hi,

On Wed, 28 Feb 2007, Andy Parkins wrote:

> +				printf("%s%i%s", add_c, added, reset);

Please use "%d" instead of "%i" (I forgot why, but I remember Junio saying that we should do it...).

> +			if (added != 0 && deleted != 0 )
> +				printf(" -> ");

Either you want to have

	Bin +123456 bytes

or

	Bin 0 -> 123456 bytes

for added files (and the obvious thing for deleted ones), but with your patch, both added and deleted get

	Bin 123456 bytes

which is not so optimal.

Ciao, Dscho