git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Show binary file size change in diff --stat

From
RDRogan Dawes <discard@dawes.za.net>
Date
Feb 28, 2007, 18:58 UTC
Message-ID
<45E5D0D7.5070305@dawes.za.net>
In-Reply-To
<200702281303.11951.andyparkins@gmail.com>
Andy Parkins wrote:
Show 24 quoted lines
> Previously, a binary file in the diffstat would show as:
> 
>  some-binary-file.bin       |  Bin
> 
> The space after the "Bin" was never used.  This patch changes binary
> lines in the diffstat to be:
> 
>  some-binary-file.bin       |  Bin +123456B -12345B
> 
> The "+" item is the size of the new version, the "-" item is the size of
> the old version.  If a size is 0 it's not shown (although it would
> probably be better to treat no-file differently from zero-byte-file).
> 
> The "B" (for bytes) is shown to highlight the fact that these numbers
> are not "number of lines", but actual bytes.
> 
> The user can see what changed in the binary file, and how big the new
> file is.  This is in keeping with the information in the rest of the
> diffstat.
> 
> The diffstat_t members "added" and "deleted" were unused when the file
> was binary, so this patch loads them with the file sizes in
> builtin_diffstat().  These figures are then read in show_stats() when
> the file is marked binary.

How about showing the size of the changes between the 2 files via the libxdiff binary patch function?

It would probably not be that difficult to generate a binary patch, and then derive some stats from it.

Rogan
Previous: Andy ParkinsNext: Johannes Schindelin
Message 9 of 13 in “Show binary file size change in diff --stat”
  1. Show binary file size change in diff --statAndy Parkins, Feb 28, 2007
  2. Johannes SchindelinFeb 28, 2007
  3. Nicolas PitreFeb 28, 2007
  4. Show binary file size change in diff --statAndy Parkins, Feb 28, 2007
  5. Johannes SchindelinFeb 28, 2007
  6. Andy ParkinsFeb 28, 2007
  7. Johannes SchindelinFeb 28, 2007
  8. Show binary file size change in diff --statAndy Parkins, Feb 28, 2007
  9. Rogan DawesFeb 28, 2007
  10. Johannes SchindelinFeb 28, 2007
  11. Rogan DawesFeb 28, 2007
  12. Johannes SchindelinMar 1, 2007
  13. Rogan DawesMar 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.