Re: [PATCH] branch as a builtin (again)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 20, 2006, 23:55 UTC
Message-ID: <Pine.LNX.4.63.0608210145200.28360@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <59ad55d30608201422h4a6d40f7y7782212637380438@mail.gmail.com>

Hi,

On Sun, 20 Aug 2006, Kristian Høgsberg wrote:

Show 9 quoted lines

> Hi,
> 
> I sent a patch to rewrite branch in C and make it a builtin a couple
> of months ago.  Junio had a few comments about the patch that I now
> finally had the time to address.  One of the problems was that
> merge-base didn't clean up its state, which has now been fixed.
> Here's the updated version.
> 
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>

Micro-nit: in delete_branches(), you can assign rev2 outside the loop.

Also, "git branch" no longer sorts the names alphabetically (you could fix this by putting the names into a path_list, which sorts them).

The "-l" option (create a log) seems to be forgotten, but then, I never use that anyway.

AFAICT the rest is fine.

Ciao, Dscho