Re: [PATCH] branch as a builtin (again)

From: Shawn Pearce <spearce@spearce.org>
Date: Aug 21, 2006, 08:03 UTC
Message-ID: <20060821080345.GA26191@spearce.org>
In-Reply-To: <Pine.LNX.4.63.0608210045450.17336@chino.corp.google.com>

> On Sun, 20 Aug 2006, Kristian Høgsberg wrote:
> > diff --git a/builtin-branch.c b/builtin-branch.c
> > +static const char builtin_branch_usage[] =
> > +    "git-branch [(-d | -D) <branchname>] | [[-f] <branchname> [<start-point>]] | -r";

What happened to the -l switch to create a reflog for the new branch?

> > +static void delete_branches(int argc, const char **argv, int force)

What happened to deleting the reflog when the branch gets deleted?

In both cases please see the existing git-branch documentation and shell script.

I applaud the effort of removing some of these smaller shell scripts with more portable C code but at the same time I'd hate to see a loss of functionality, especially something that I use! :-)

-- 
Shawn.