Re: [PATCH] branch as a builtin (again)
- From
Kristian Høgsberg <krh@bitplanet.net>
- Date
- Aug 21, 2006, 21:07 UTC
- Message-ID
- <59ad55d30608211407v74e1369dw17fae16933c0356f@mail.gmail.com>
- In-Reply-To
- <Pine.LNX.4.63.0608212227040.28360@wbgn013.biozentrum.uni-wuerzburg.de>
On 8/21/06, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 9 quoted lines
> Hi, > > On Mon, 21 Aug 2006, Kristian Hxgsberg wrote: > > > Thanks to all who reviewed the patch, here's an updated version which > > should address all issues. > > I would have preferred the use of path_list instead of rolling your own > thing with qsort(), but oh well.
Yeah, I saw that, but since I got flack for computing lookup_commit_reference(head_sha1) inside the delete_branches loop, I couldn't possibly risk the performance bottle neck of listing the branches using a O(n^2) insertion sort.
Kristian