git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's in git.git, and announcing GIT 1.4.2-rc4

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 10, 2006, 07:47 UTC
Message-ID
<Pine.LNX.4.63.0608100945430.13885@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vfyg5xi02.fsf@assigned-by-dhcp.cox.net>
Hi,
On Wed, 9 Aug 2006, Junio C Hamano wrote:
Show 5 quoted lines
> +
> +	/* NUL terminate the result */
> +	if (desc.alloc <= desc.size) {
> +		desc.buffer = xrealloc(desc.buffer, desc.size + 1);
> +		desc.alloc++;

While in this particular case, desc.alloc cannot be smaller than desc.size (and therefore the condition in the if() is misleading), it might be better to write "desc.alloc = desc.size + 1;" for others to understand...

Ciao, Dscho

Previous: Willy TarreauNext: Junio C Hamano
Message 6 of 14 in “What's in git.git, and announcing GIT 1.4.2-rc4”
  1. Junio C HamanoAug 10, 2006
  2. Willy TarreauAug 10, 2006
  3. Junio C HamanoAug 10, 2006
  4. Junio C HamanoAug 10, 2006
  5. Willy TarreauAug 10, 2006
  6. Johannes SchindelinAug 10, 2006
  7. Junio C HamanoAug 10, 2006
  8. Johannes SchindelinAug 10, 2006
  9. Junio C HamanoAug 10, 2006
  10. Junio C HamanoAug 10, 2006
  11. Johannes SchindelinAug 10, 2006
  12. Alex RiesenAug 10, 2006
  13. Johannes SchindelinAug 10, 2006
  14. Alex RiesenAug 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.