git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's in git.git, and announcing GIT 1.4.2-rc4

From
Willy Tarreau <w@1wt.eu>
Date
Aug 10, 2006, 03:34 UTC
Message-ID
<20060810033448.GH8776@1wt.eu>
In-Reply-To
<7vy7txxts5.fsf@assigned-by-dhcp.cox.net>
Hi Junio,
On Wed, Aug 09, 2006 at 06:29:30PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> GIT 1.4.2-rc4
> 
> It's been a week since -rc3, so here it is.  The changes are
> really small fixes and nothing else.  Let's hope I can tag the
> real 1.4.2 this weekend.

I encountered a problem in 1.4.1 and 1.4-git about 2 weeks ago (I've not tried 1.4.2-rc4 yet). When applying a git patch which contains a symlink, the symlink created on the filesystem sometimes has a wrong name with some chars appended to its end, such as if its name was not zero-terminated. I always encountered this only when there were several symlinks in the patch, eg: you create a symlink first, then commit, then change its dest, then commit, then git-format-patch and try to apply both patches (git-am -k -3) to another tree. Generally, the second link will be broken. The index will be OK however, since git-status will complain about it.

I've tried to find the reason for this problem in the code, but failed to do so. I remember that the function which calls symlink() (I don't remember its name, sorry) already gets an invalid name in path->name or something like this.

That's all I could do because I was really too short in time, and I'm sorry I really don't have enough time to track this further right now. However, if you have some time to reproduce it and have questions, I'm willing to respond you.

Thanks, and sorry again for the lack of information, Willy

Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 14 in “What's in git.git, and announcing GIT 1.4.2-rc4”
  1. Junio C HamanoAug 10, 2006
  2. Willy TarreauAug 10, 2006
  3. Junio C HamanoAug 10, 2006
  4. Junio C HamanoAug 10, 2006
  5. Willy TarreauAug 10, 2006
  6. Johannes SchindelinAug 10, 2006
  7. Junio C HamanoAug 10, 2006
  8. Johannes SchindelinAug 10, 2006
  9. Junio C HamanoAug 10, 2006
  10. Junio C HamanoAug 10, 2006
  11. Johannes SchindelinAug 10, 2006
  12. Alex RiesenAug 10, 2006
  13. Johannes SchindelinAug 10, 2006
  14. Alex RiesenAug 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.