From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 10 Aug 2006 07:47:27 GMT
Subject: Re: What's in git.git, and announcing GIT 1.4.2-rc4
Message-ID: <Pine.LNX.4.63.0608100945430.13885@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vfyg5xi02.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 9 Aug 2006, Junio C Hamano wrote:

> +
> +	/* NUL terminate the result */
> +	if (desc.alloc <= desc.size) {
> +		desc.buffer = xrealloc(desc.buffer, desc.size + 1);
> +		desc.alloc++;

While in this particular case, desc.alloc cannot be smaller than desc.size 
(and therefore the condition in the if() is misleading), it might be 
better to write "desc.alloc = desc.size + 1;" for others to understand...

Ciao,
Dscho