Re: [PATCH] Introduce Git.pm (v3)

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Jun 25, 2006, 01:54 UTC

Message-ID

<Pine.LNX.4.63.0606250353220.29667@wbgn013.biozentrum.uni-wuerzburg.de>

In-Reply-To

<7vzmg2rpxt.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 24 Jun 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > My original idea: on a machine where you have no accurate diff, you at 
> > least want to pass the tests, and you want to ensure you can apply a diff 
> > you generated on that machine.
> 
> I remember that, but I think recently we converted t4100 and
> t4101 to use pregenerated test vectors so it might not be an
> issue anymore?

Exactly.

> I would maybe rename the option to --inaccurate-eof and default
> it to off (i.e. no --accurate-eof option).  After all we are not
> talking about arbitrary inaccuracy but the particular botch of
> not having "\No newline at the end of file."

Sure. Want me to redo the patch?