Re: [PATCH] Introduce Git.pm (v3)
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jun 22, 2006, 23:18 UTC
- Message-ID
- <7vlkrohj9p.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060622220201.19132.67536.stgit@machine.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 11 quoted lines
> * Added hash_object() and Git.xs providing the fast implementation > * Better error reporting > * Plenty of random minor stuff > > It's a good thing v2 didn't make it to the list since it contained a huge > file which turns out that can be autogenerated at the build time, so v3 > just changes that (and adds .gitignore file and makes some other minor > changes). > > I consider this patch "stable" now. Further enhancements will be posted > as patches on top of this.
Eek. It does not compile for me -- maybe there is more dependencies that need to be listed in INSTALL file?
make -C perl make[1]: Entering directory `/opt/git/git.git/perl' cc -c -I. -I.. -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"0.01\" -DXS_VERSION=\"0.01\" -fPIC "-I/usr/lib/perl/5.8/CORE" -O2 -Wall -Wdeclaration-after-statement -g -DSHA1_HEADER='<openssl/sha.h>' Git.c Git.xs: In function 'XS_Git_xs_hash_object': Git.xs:27: warning: ISO C90 forbids mixed declarations and code Git.xs:44: warning: passing argument 1 of 'Perl_io_close' from incompatible pointer type Git.xs:44: warning: passing argument 2 of 'Perl_io_close' makes pointer from integer without a cast Git.xs:44: error: too few arguments to function 'Perl_io_close' make[1]: *** [Git.o] Error 1 make[1]: Leaving directory `/opt/git/git.git/perl' make: *** [all] Error 2