Re: [PATCH] Introduce Git.pm (v3)

From: Junio C Hamano <junkio@cox.net>
Date: Jun 24, 2006, 01:07 UTC
Message-ID: <7vzmg35pkt.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vejxf74e3.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 9 quoted lines

>> It should be enough to -I../perl/blib/lib -I../perl/blib/arch/auto/Git.
>
> -- >8 --
> [PATCH] Perl interface: add build-time configuration to allow building with -fPIC
>
> On x86-64 it seems that Git.xs does not link without compiling
> the main git objects with -fPIC.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>

Eh, sorry this was in response to this part of Pasky's message:

Show 5 quoted lines

>> Well, for the .xs you do need an .so and for that you apparently need
>> -fPIC on most architectures, so there's no way around it.
>> 
>> There's a patch to build libgit.so, would you take it as an excuse to
>> always compile with -fPIC? ;-)

By the way, I noticed NO_ACCURATE_DIFF is a compile time option to cause git-apply to accept diff output from implementations that botch "\No newline at the end of file", and I think it is wrong -- it should be a run time option to git-apply if we would want to support it, because the version of diff you have does not have much to do with which implementations of diff were used to generate patches you would receive and apply.

Thoughts?