Re: [PATCH] Fix git_setup_directory_gently when GIT_DIR is set

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 6, 2006, 05:39 UTC
Message-ID: <Pine.LNX.4.63.0606060735400.29431@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vmzcr14ao.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 5 Jun 2006, Junio C Hamano wrote:

Show 10 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
> 
> > I know clone currently relies on init-db to create the directory if
> > it does not exist (I wrote the code after all).
> 
> Ah, I think I see the real problem is.  Alias handling is done
> too early, and for commands like init-db that does _not_ even
> want to look at an existing repository it tries to use GIT_DIR.
> 
> So how about this patch instead on top of yours?

Yes, I like it. I was so focused on reading the config early to be done with it, and avoiding reading the config twice (which it can do now, with your patch, but only if one is so insane to use nested aliases).

Your method of avoiding shadowing proper git commands is elegant, if maybe incomplete: you have no way of warning the user that the alias is not used. But then, I do not think that matters.

Ciao, Dscho