Re: [PATCH] Fix git_setup_directory_gently when GIT_DIR is set

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 5, 2006, 22:57 UTC
Message-ID: <Pine.LNX.4.63.0606060053440.25344@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vodx74ca9.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 5 Jun 2006, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > When calling git_setup_directory_gently, and GIT_DIR was set, it just
> > ignored the variable nongit_ok.
> 
> Hmph.  Is this really a breakage?  That is, gently() is meant
> for a case where you do not know if you even find a git
> repository and tell it not to complain because you are prepared
> for the case where you are not in a git repository.

Yes, it is a breakage: in git-clone, line 212, we explicitely set GIT_DIR (to the not-yet-existing repository path), and call git-init-db. Now, with the alias thing we need to get the config if it exists, so we _got_ to call gently(). Boom.

Ciao, Dscho