Re: [PATCH] Fix git_setup_directory_gently when GIT_DIR is set
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jun 5, 2006, 23:10 UTC
- Message-ID
- <7vk67v2o85.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0606060053440.25344@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 18 quoted lines
> Hi, > > On Mon, 5 Jun 2006, Junio C Hamano wrote: > >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> >> > When calling git_setup_directory_gently, and GIT_DIR was set, it just >> > ignored the variable nongit_ok. >> >> Hmph. Is this really a breakage? That is, gently() is meant >> for a case where you do not know if you even find a git >> repository and tell it not to complain because you are prepared >> for the case where you are not in a git repository. > > Yes, it is a breakage: in git-clone, line 212, we explicitely set GIT_DIR > (to the not-yet-existing repository path), and call git-init-db. Now, with > the alias thing we need to get the config if it exists, so we _got_ to > call gently(). Boom.
Hmph. Would it be a bug in clone that does not create GIT_DIR then?