Re: [PATCH] fmt-patch: Support --attach

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 20, 2006, 20:23 UTC
Message-ID: <Pine.LNX.4.63.0605202214430.634@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vu07k1sr8.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 20 May 2006, Junio C Hamano wrote:

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sat, 20 May 2006, Junio C Hamano wrote:
> >
> > As for --check: how about having yet another diff "format": 
> > DIFF_FORMAT_CHECK? Instead of showing the diff, it only shows the line(s) 
> > which are offending.
> 
> Never thought of that but I think it makes sense.  
> 
> I liked the way Sean did the --summary; I am wondering if we
> could clean up the --with-* stuff in a similar way.  We
> currently do "if DIFF_FORMAT_XYZ or with_xyz then do this" which
> is quite honestly disgusting (my fault).

I do not think the --with-* stuff can be done in a similar way. If I do "git log --summary -p", I do not get a summary. The only way to "clean it up" would be to add a linked list of diff_formats (to preserve the order).

But frankly, I think that is overkill. After all, how often have you dreamt about showing first the patch, then the summary, and maybe a diffstat, and after that the patch again, for each commit?

Ciao, Dscho