Re: [PATCH] fmt-patch: Support --attach

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 20, 2006, 17:51 UTC
Message-ID: <Pine.LNX.4.63.0605201945110.32590@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v4pzk3831.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 20 May 2006, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > I only changed the "From " line (note the missing ":") to match the output 
> > from git-format-patch.sh.
> 
> Not a big deal, but I was hoping you would keep the inception
> date of git (April one) in the final version ;-).  The September
> date is totally a random date and does not have any
> significance.

Actually, I just tested something: pine seems to be confused when parsing a "From " line where the day of month is only one digit without two leading digits. I don't care.

> Anyway, with this change (and a lot of testing ;-) I think we
> can replace the script with built-in.  Thanks.

There are two options missing: --signoff and --check.

--signoff is my fault: it is probably a good thing to drop it from format-patch, and only leave it in applymbox.

As for --check: how about having yet another diff "format": DIFF_FORMAT_CHECK? Instead of showing the diff, it only shows the line(s) which are offending.

Ciao, Dscho