Re: [PATCH] fmt-patch: Support --attach

From: Junio C Hamano <junkio@cox.net>
Date: May 20, 2006, 18:00 UTC
Message-ID: <7vu07k1sr8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0605201945110.32590@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

> On Sat, 20 May 2006, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> There are two options missing: --signoff and --check.
>
> --signoff is my fault: it is probably a good thing to drop it from 
> format-patch, and only leave it in applymbox.

I think that is fine. format-patch only formats existing commits, and if you are signing off something you could already have done that when you made the commits anyway, so that flag was redundant.

> As for --check: how about having yet another diff "format": 
> DIFF_FORMAT_CHECK? Instead of showing the diff, it only shows the line(s) 
> which are offending.

Never thought of that but I think it makes sense.

I liked the way Sean did the --summary; I am wondering if we could clean up the --with-* stuff in a similar way. We currently do "if DIFF_FORMAT_XYZ or with_xyz then do this" which is quite honestly disgusting (my fault).