Re: ALSA official git repository

From: Jesper Juhl <juhl-lkml@dif.dk>
Date: May 27, 2005, 21:18 UTC
Message-ID: <Pine.LNX.4.62.0505272313450.2400@dragon.hyggekrogen.localhost>
In-Reply-To: <20050527135124.0d98c33e.akpm@osdl.org>

On Fri, 27 May 2005, Andrew Morton wrote:

Show 39 quoted lines

> Linus Torvalds <torvalds@osdl.org> wrote:
> >
> > 
> > 
> > On Fri, 27 May 2005, Jaroslav Kysela wrote:
> > > 
> > > Okay, sorry for this small bug. I'll recreate the ALSA git tree with
> > > proper comments again. Also, the author is not correct (should be taken
> > > from the first Signed-off-by:).
> > 
> > Hmm.. That's not always true in general, since Sign-off does allow to sign
> > off on other peoples patches (see the "(b)" clause in DCO), but maybe in
> > the ALSA tree it is.
> 
> Yes, I'll occasionally do patches which were written by "A" as:
> 
> From: A
> ...
> Signed-off-by: B
> 
> And that comes through email as:
> 
> 
> ...
> From: <akpm@osdl.org>
> ...
> From: A
> ...
> Signed-off-by: B
> 
> 
> which means that the algorithm for identifying the author is "the final
> From:".
> 
> I guess the bug here is the use of From: to identify the primary author,
> because transporting the patch via email adds ambiguity.
> 
> Maybe we should introduce "^Author:"?
>

That might be good. I honestly don't know what would be the best solution, but what happens often at the moment is that patches get passed on as "From" whatever maintainer (or random resender) happened to pass it on to Andrew/Linus and that person then effectively gets labeled as the author of the patch in the changelogs/git/whatever. That's not perfect...

Author: might solve it.. worth a shot if you ask me..

-- 
Jesper Juhl