Re: ALSA official git repository

From: Junio C Hamano <junkio@cox.net>
Date: May 27, 2005, 18:47 UTC
Message-ID: <7vvf54y092.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0505271026020.17402@ppc970.osdl.org>

>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> On Fri, 27 May 2005, Sean wrote:

Show 9 quoted lines

>> >
>> > Now, arguably gitweb should ignore whitespace at the beginning, but
>> > equally arguably your commits shouldn't have them either...
>> 
>> Perhaps git should enforce this?  Patch attached.
>> 
>> Remove leading empty lines from commit messages.
>> 
>> Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>

LT> I'm not sure. LT> Opinions?

Porcelains and gitweb should play with each other nicely, but the core should _not_ care by default.

An extra option ("--text", perhaps) to git-commit-tree is acceptable to me, and it may be even a good thing to have. It would make life a bit easiear for Porcelain writers if nothing else. If that is to happen, I would say we could do more than just leading blank line removal. We can also remove trailing blanks before each LF, tabify indented log message contents, and remove empty lines before EOF.