Re: ALSA official git repository

From: Linus Torvalds <torvalds@osdl.org>
Date: May 27, 2005, 17:28 UTC
Message-ID: <Pine.LNX.4.58.0505271026020.17402@ppc970.osdl.org>
In-Reply-To: <3516.10.10.10.24.1117213207.squirrel@linux1>

On Fri, 27 May 2005, Sean wrote:

Show 9 quoted lines

> >
> > Now, arguably gitweb should ignore whitespace at the beginning, but
> > equally arguably your commits shouldn't have them either...
> 
> Perhaps git should enforce this?  Patch attached.
> 
> Remove leading empty lines from commit messages.
> 
> Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>

I'm not sure.

The thing is, right now git allows binary commit messages if somebody really wants to. Now, a lot of the _tools_ end up only printing up to the first '\0' or something, but in general, maybe somebody actually wants to embed his own strange stuff in there (eg use encryption but still use standard git tools).

Which makes me worry. So I _do_ do whitespace cleanup in my "apply email patches" scripts, but I'm not sure whether the core should care about the data that people feed it, even for commit messages.

Opinions?

		Linus