git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitk SHA link hovers

From
Linus Torvalds <torvalds@osdl.org>
Date
Aug 6, 2005, 17:59 UTC
Message-ID
<Pine.LNX.4.58.0508061056200.3258@g5.osdl.org>
In-Reply-To
<Pine.LNX.4.58.0508060919150.3258@g5.osdl.org>

This makes the cursor change when you hover over a SHA1 link with the new "hypertext" gitk commit ID linking feature.

All credit goes to Jeff Epler <jepler@unpythonic.net> and bugs are mine. I don't actually know any tcl/tk, I'm just acting as a random monkey that looks at what others do and mix it up.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
----
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -1802,10 +1802,13 @@ proc selectline {l isnew} {
 	set linkid [string range $comment $s $e]
 	if {![info exists idline($linkid)]} continue
 	incr e
-	$ctext tag conf link$i -foreground blue -underline 1
+	$ctext tag add link "$commentstart + $s c" "$commentstart + $e c"
 	$ctext tag add link$i "$commentstart + $s c" "$commentstart + $e c"
 	$ctext tag bind link$i <1> [list selectline $idline($linkid) 1]
     }
+    $ctext tag conf link -foreground blue -underline 1
+    $ctext tag bind link <Enter> { %W configure -cursor hand2 }
+    $ctext tag bind link <Leave> { %W configure -cursor {} }
 
     $ctext tag delete Comments
     $ctext tag remove found 1.0 end
Previous: jepler@unpythonic.netNext: Paul Mackerras
Message 22 of 25 in “Display of merges in gitk”
  1. Paul MackerrasJul 30, 2005
  2. Junio C HamanoJul 30, 2005
  3. Shipping gitk as part of core git.Junio C Hamano, Jul 30, 2005
  4. Paul MackerrasJul 31, 2005
  5. Junio C HamanoJul 31, 2005
  6. gitk merge display bugs (was: Re: Display of merges in gitk)Sergey Vlasov, Jul 30, 2005
  7. Linus TorvaldsAug 5, 2005
  8. gitk "hyperlinks" (was Re: Display of merges in gitk)Linus Torvalds, Aug 5, 2005
  9. jepler@unpythonic.netAug 5, 2005
  10. Kay SieversAug 6, 2005
  11. Linus TorvaldsAug 6, 2005
  12. Kay SieversAug 7, 2005
  13. gitweb "tag" displayJunio C Hamano, Aug 6, 2005
  14. Junio C HamanoAug 6, 2005
  15. Paul MackerrasAug 19, 2005
  16. Johannes SchindelinAug 19, 2005
  17. Junio C HamanoAug 20, 2005
  18. Kay SieversAug 7, 2005
  19. Paul MackerrasAug 6, 2005
  20. Linus TorvaldsAug 6, 2005
  21. jepler@unpythonic.netAug 6, 2005
  22. gitk SHA link hoversLinus Torvalds, Aug 6, 2005
  23. Paul MackerrasAug 7, 2005
  24. Junio C HamanoAug 6, 2005
  25. Paul MackerrasAug 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.