Re: gitk "hyperlinks"

From: Junio C Hamano <junkio@cox.net>
Date: Aug 6, 2005, 16:31 UTC
Message-ID: <7vpssr9gd1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <17140.47152.672091.474748@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> Good idea.  Also done. :)  It's on master.kernel.org now in my gitk.git
> directory.  Hopefully Junio will pull it into git soon.

I did, and will push it out shortly, but I think you need this patch. To make later merges from you easier, I will not put this in my "master" branch.

------------ [PATCH] gitk proposed fix: handle more than one SHA1 links.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

c423b62a66d4c4f2a7856cada507f973e9140590

diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -1802,6 +1802,7 @@ proc selectline {l isnew} {
 	set linkid [string range $comment $s $e]
 	if {![info exists idline($linkid)]} continue
 	incr e
+	incr i
 	$ctext tag conf link$i -foreground blue -underline 1
 	$ctext tag add link$i "$commentstart + $s c" "$commentstart + $e c"
 	$ctext tag bind link$i <1> [list selectline $idline($linkid) 1]