git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitk "hyperlinks" (was Re: Display of merges in gitk)

From
Linus Torvalds <torvalds@osdl.org>
Date
Aug 5, 2005, 14:37 UTC
Message-ID
<Pine.LNX.4.58.0508050710460.3258@g5.osdl.org>
In-Reply-To
<Pine.LNX.4.58.0508050658260.3258@g5.osdl.org>
[ Also Kay Sievers, because the clickability thing sounds like a 
  potentially good thing for webgit too.. ]

For 2.6.13 we've been reverting some stuff lately, to make sure we get a stable release. That's fine, and when I revert something I try to mention the commit ID of the thing I revert in the message. Apparently others do too, as indicated by a patch I just got from Petr Vandovec. So we've got for example:

	889371f61fd5bb914d0331268f12432590cf7e85:
	Author: Linus Torvalds <torvalds@g5.osdl.org>  2005-07-30 13:41:56
	Committer: Linus Torvalds <torvalds@g5.osdl.org>  2005-07-30 13:41:56
    Revert "yenta free_irq on suspend"
    
    ACPI is wrong.  Devices should not release their IRQ's on suspend and
    re-aquire them on resume.  ACPI should just re-init the IRQ controller
    instead of breaking most drivers very subtly.
    
    Breakage reported by Hugh Dickins <hugh@veritas.com>
    
    Undo: d8c4b4195c7d664baf296818bf756775149232d3
    
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
and
	403fe5ae57c831968c3dbbaba291ae825a1c5aaa:
	Author: Petr Vandrovec <vandrove@vc.cvut.cz>  2005-08-05 06:50:07
	Committer: Linus Torvalds <torvalds@g5.osdl.org>  2005-08-05 06:57:44
    [PATCH] rtc: msleep() cannot be used from interrupt
    
    Since the beginning of July my Opteron box was randomly crashing and
    being rebooted by hardware watchdog.  Today it finally did it in front
    of me, and this patch will hopefully fix it.
    
    The problem is that at the end of June (the 28th, to be exact: commit
    47f176fdaf8924bc83fddcf9658f2fd3ef60d573, "[PATCH] Using msleep()
    instead of HZ") rtc_get_rtc_time ...

and when I use gitk, it would be just too damn cool for words if I could easily follow the SHA1's mentioned in the commit message.

I can just cut-and-paste the SHA1, and I've verified that it works fine. However, as you'v enoticed, I'm of the whiny kind, and I thought it could be easier. So I'm whining again.

<whine>Mommy, mommy, can you make my life easier</whine>
So I noticed that I really would like two things:
 - "clickable" SHA1's in commit messages would be really really cool if 
   something like that is even possible with tcl/tk.
   Now, if you can highlight them when showing the message, that would be 
   extra cool, but even without any highlighing, the thing actually 
   _almost_ works fine already: you can double-click the SHA1, and it will 
   select it. You then have to move the mouse to the "goto" window, and 
   paste in the SHA1 there. And this is where it would be good if this 
   sequence could be simplified a bit.
   Even if it's something as simple as accepting the SHA1 paste into the 
   same window (not having to go to the "goto" window: just double-click 
   on the SHA1, and then right-click to "paste it back").
 - I'd like to have a "back button". Not just for the above kind of thing, 
   but in general too: when searching for something, it would just be very 
   nice if gitk just kept a list of the <n> last commits that have 
   been selected, and there was a web-browser-like button that went 
   back/forward in history.
   But especially when looking at a revert, I just want to first go to the 
   thing we revert, see what's going on there (get the "historical 
   perspective" - commit log for why the original was done etc), and then 
   I'd want to go back (and possibly forth and back again ;). And while 
   the revert mentioned the thing it reverted (so I could cut-and-paste), 
   the thing it reverted obviously does _not_ mention the thing that 
   reverted it, so now I have to manually just scroll back.
   This same thing happens for a failed search (I search for xyz, and it 
   actually finds it, and I realize that that was the wrong search, but
   now I'm two months back..)
<whine>Mommy, mommy, pleeeease</whine>
			Linus
Previous: Linus TorvaldsNext: jepler@unpythonic.net
Message 8 of 25 in “Display of merges in gitk”
  1. Paul MackerrasJul 30, 2005
  2. Junio C HamanoJul 30, 2005
  3. Shipping gitk as part of core git.Junio C Hamano, Jul 30, 2005
  4. Paul MackerrasJul 31, 2005
  5. Junio C HamanoJul 31, 2005
  6. gitk merge display bugs (was: Re: Display of merges in gitk)Sergey Vlasov, Jul 30, 2005
  7. Linus TorvaldsAug 5, 2005
  8. gitk "hyperlinks" (was Re: Display of merges in gitk)Linus Torvalds, Aug 5, 2005
  9. jepler@unpythonic.netAug 5, 2005
  10. Kay SieversAug 6, 2005
  11. Linus TorvaldsAug 6, 2005
  12. Kay SieversAug 7, 2005
  13. gitweb "tag" displayJunio C Hamano, Aug 6, 2005
  14. Junio C HamanoAug 6, 2005
  15. Paul MackerrasAug 19, 2005
  16. Johannes SchindelinAug 19, 2005
  17. Junio C HamanoAug 20, 2005
  18. Kay SieversAug 7, 2005
  19. Paul MackerrasAug 6, 2005
  20. Linus TorvaldsAug 6, 2005
  21. jepler@unpythonic.netAug 6, 2005
  22. gitk SHA link hoversLinus Torvalds, Aug 6, 2005
  23. Paul MackerrasAug 7, 2005
  24. Junio C HamanoAug 6, 2005
  25. Paul MackerrasAug 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.