git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Modify git-rev-list ... in merge order [ repost with bug fixes ]

From
Linus Torvalds <torvalds@osdl.org>
Date
Jun 6, 2005, 01:43 UTC
Message-ID
<Pine.LNX.4.58.0506051842310.1876@ppc970.osdl.org>
In-Reply-To
<2cfc4032050605180958fcf395@mail.gmail.com>
On Mon, 6 Jun 2005, Jon Seymour wrote:
> 
> My rationale was to re-use both the filtering logic currently in the
> show_commit_list while loop and the display logic, since I need both
> in order to maximise compatibility with the standard algorithm.

It's obviously ok to re-use the filtering, I'm just objecting to putting it into a function that is really unrelated to filtering..

> My plan, therefore, is to split the filtering logic from
> show_commit_list's while loop into a separate function and create a
> third function which calls the filtering logic, then show_commit.
Yes.
		Linus
Previous: Jon Seymour
Message 4 of 4 in “Modify git-rev-list ... in merge order [ repost with bug fixes ]”
  1. Modify git-rev-list ... in merge order [ repost with bug fixes ]jon@blackcubes.dyndns.org, Jun 5, 2005
  2. Linus TorvaldsJun 6, 2005
  3. Jon SeymourJun 6, 2005
  4. Linus TorvaldsJun 6, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.