From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 06 Jun 2005 01:43:44 GMT
Subject: Re: [PATCH] Modify git-rev-list ... in merge order [ repost with bug fixes ]
Message-ID: <Pine.LNX.4.58.0506051842310.1876@ppc970.osdl.org>
In-Reply-To: <2cfc4032050605180958fcf395@mail.gmail.com>



On Mon, 6 Jun 2005, Jon Seymour wrote:
> 
> My rationale was to re-use both the filtering logic currently in the
> show_commit_list while loop and the display logic, since I need both
> in order to maximise compatibility with the standard algorithm.

It's obviously ok to re-use the filtering, I'm just objecting to putting
it into a function that is really unrelated to filtering..

> My plan, therefore, is to split the filtering logic from
> show_commit_list's while loop into a separate function and create a
> third function which calls the filtering logic, then show_commit.

Yes.

		Linus