git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Modify git-rev-list ... in merge order [ repost with bug fixes ]

From
Linus Torvalds <torvalds@osdl.org>
Date
Jun 6, 2005, 00:44 UTC
Message-ID
<Pine.LNX.4.58.0506051741190.1876@ppc970.osdl.org>
In-Reply-To
<20050605134733.3123.qmail@blackcubes.dyndns.org>
On Sun, 5 Jun 2005 jon@blackcubes.dyndns.org wrote:
>  
> -static void show_commit(struct commit *commit)
> +static int show_commit(struct commit *commit)
Ick. You've mixed "show_commit()" to be three totally independent things
 - deciding whether to show at all
 - showing the commit in traditional format
 - showing the commit tree in the new "break" format

I really hate functions that do totally unrelated things, and I'm so much happier with the new show_commit() than the old "everything in one big function" thing, that I'm unhappy about mixing the thing up again.

Please leave show_commit() to just show the commit, and make the other decisions be independent of that.

		Linus
Previous: jon@blackcubes.dyndns.orgNext: Jon Seymour
Message 2 of 4 in “Modify git-rev-list ... in merge order [ repost with bug fixes ]”
  1. Modify git-rev-list ... in merge order [ repost with bug fixes ]jon@blackcubes.dyndns.org, Jun 5, 2005
  2. Linus TorvaldsJun 6, 2005
  3. Jon SeymourJun 6, 2005
  4. Linus TorvaldsJun 6, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.