From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 06 Jun 2005 00:44:56 GMT
Subject: Re: [PATCH] Modify git-rev-list ... in merge order [ repost with bug fixes ]
Message-ID: <Pine.LNX.4.58.0506051741190.1876@ppc970.osdl.org>
In-Reply-To: <20050605134733.3123.qmail@blackcubes.dyndns.org>



On Sun, 5 Jun 2005 jon@blackcubes.dyndns.org wrote:
>  
> -static void show_commit(struct commit *commit)
> +static int show_commit(struct commit *commit)

Ick. You've mixed "show_commit()" to be three totally independent things
 - deciding whether to show at all
 - showing the commit in traditional format
 - showing the commit tree in the new "break" format

I really hate functions that do totally unrelated things, and I'm so much 
happier with the new show_commit() than the old "everything in one big 
function" thing, that I'm unhappy about mixing the thing up again.

Please leave show_commit() to just show the commit, and make the other 
decisions be independent of that.

		Linus