Re: gitweb wishlist

From: Linus Torvalds <torvalds@osdl.org>
Date: May 24, 2005, 20:33 UTC
Message-ID: <Pine.LNX.4.58.0505241316490.2307@ppc970.osdl.org>
In-Reply-To: <Pine.LNX.4.58.0505241259250.2307@ppc970.osdl.org>

On Tue, 24 May 2005, Linus Torvalds wrote:

Show 6 quoted lines

> 
> Exactly because it's only blobs, it really does smell like a cvsps issue. 
> My scripts always use "git-update-cache --add -- filename", so it never 
> creates any blobs _except_ when it adds them to the index (and thus 
> write-tree should always pick them up, unless we update the index again 
> before the next write-tree happens).

Looking at the contents of these files, all but one of them are changelog files, which would be consistent with this theory - if gitps ends up "smushing together" two separate commits (and mutt seems to have the bad habit of having just a simple "# changelog commit" as the commit message, so it would likely trigger the "same commit message" logic), you'd get exactly this.

The one non-changelog file looks like some kind of message translation thing:

	# This file was prepared by (in alphabetical order):
	#
	#   Alexey Vyskubov (alexey@pepper.spb.ru)
	#   Andrew W. Nosenko (awn@bcs.zp.ua)
	#   Michael Sobolev (mss@transas.com)
	#   Vsevolod Volkov (vvv@mutt.org.ua)
	#
	# To contact translators, please use mutt-ru mailing list:
	#   http://woe.spb.ru/mailman/listinfo/mutt-ru
	#
	msgid ""
	msgstr ""
	"Project-Id-Version: mutt-1.4i\n"
	"POT-Creation-Date: 2002-05-02 01:08+0200\n"
	"PO-Revision-Date: 2002-05-03 22:53+0300\n"

...

	#: alias.c:280
	#, c-format
	msgid "[%s = %s] Accept?"
	msgstr "[%s = %s] ðÒÉÎÑÔØ?"

...

and it looks like it is "po/ru.po". Indeed, that's a big clue:

	---------------------
	PatchSet 2869 
	Date: 2002/05/13 21:17:48
	Author: roessler
	Branch: mutt-1-4-stable
	Tag: (none) 
	Log:
	From: Vsevolod Volkov <vvv@mutt.org.ua>
	
	update
	
	Members: 
	        po/ru.po:1.129.2.5->1.129.2.6 
	        po/ru.po:1.129.2.4->1.129.2.5 
	
	---------------------

and I thus rest my case. cvs2git is doing the right thing, and this is something that needs to be fixed in cvsps in case anybody cares.

		Linus