Re: gitweb wishlist
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- May 24, 2005, 19:34 UTC
- Message-ID
- <Pine.LNX.4.58.0505241212190.2307@ppc970.osdl.org>
- In-Reply-To
- <20050524184612.GA23637@cip.informatik.uni-erlangen.de>
On Tue, 24 May 2005, Thomas Glanzmann wrote:
Show 6 quoted lines
> > I have the following issues all seem easy to fix: > > - PatchSet 1 depends on PatchSet 2 (but cvsps gets the ordering wrong; > should be easy fixable) (I just swichted the two before > running cvs2git)
Ok, this seems to be a cvsps bug, and I'll treat it as such. David, any ideas? It seems to be because of how cvsps sorts things by date, which is obviously bogus.
The cvs2git thing wouldn't normally even _care_ (ie would happily re-order the thing), but for the fact that it causes problems with branches that are used before they are created in this case.
cvsps really should do some kind of topo-sort. Probably doesn't need a lot (ie it probably doesn't even need to be topological, but the "order" should be based on trivial dependencies first, and time second. For example, once David does the per-commit branch handling, I suspect enough of an ordering to keep git happy falls out of that).
> - Some Shell escapes (I didn't looked into them yet)
Ok, I'll check it out. I didn't figure out what characters are shell-expanded by "<<EOF" handling, and only did '$' because that showed up in the syslinux archives.
Show 6 quoted lines
> (faui02new) [/var/tmp/sithglan/mutt-cvs] git parent ~/work/mutt/git/mutt-cvs > (faui02new) [/var/tmp/sithglan/mutt-cvs] git parentdiff > (faui02new) [/var/tmp/sithglan/mutt-cvs] > > I think I will run my 'import patch by patch script again' and check the > changesets against the cvs2git tree, but it looks fine for me.
In theory, they should give the exact same results, no? At least if there are no binary objects. Of course, you'd have to update your import script to do the times the same way.
Linus