git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: I'm missing isofs.h

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 28, 2005, 16:28 UTC
Message-ID
<Pine.LNX.4.58.0504280918230.18901@ppc970.osdl.org>
In-Reply-To
<7vvf6698zq.fsf@assigned-by-dhcp.cox.net>
On Thu, 28 Apr 2005, Junio C Hamano wrote:
> 
> Is /dev/null convention OK with you?

Absolutely. In fact, I prefer it, but I end up just using standard "patch -p1" in the end, so..

> Here is an example of diffstat getting confused:

diffstat is _way_ too easily confused by various things. I've seen it claim "no files" just because the diff had some headers that confused it. And yes, you should always tell it to use "-p1" to get the right pathnames, otherwise it does nonsensical things (if all the diffs happen to be in "drivers/usb/" it ends up deciding that that's just a common prefix, and won't actually show it at all).

However, I'm surprised that it's confused by /dev/null. Usually the confusion comes from the stuff _after_ the name (ie adding the "mode" etc is what I'd have expected to confuse it).

One way to un-confuse diffstat is to add the "Index: " line. I'm not actually much of a fan of Index: lines myself, and I'd rather somebody fixed diffstat, but they _do_ work around diffstat problems.

		Linus
Previous: Junio C HamanoNext: David A. Wheeler
Message 18 of 23 in “I'm missing isofs.h”
  1. Andrew MortonApr 27, 2005
  2. Jan HarkesApr 27, 2005
  3. Petr BaudisApr 27, 2005
  4. Jan HarkesApr 27, 2005
  5. Jan HarkesApr 27, 2005
  6. Steven ColeApr 27, 2005
  7. Steven ColeApr 27, 2005
  8. Petr BaudisApr 27, 2005
  9. Linus TorvaldsApr 28, 2005
  10. Petr BaudisApr 28, 2005
  11. Junio C HamanoApr 28, 2005
  12. Junio C HamanoApr 28, 2005
  13. Make diff-cache and friends output more cg-patch friendly.Junio C Hamano, Apr 28, 2005
  14. Petr BaudisApr 28, 2005
  15. David A. WheelerApr 28, 2005
  16. Linus TorvaldsApr 28, 2005
  17. Junio C HamanoApr 28, 2005
  18. Linus TorvaldsApr 28, 2005
  19. Cogito nit: cg-update should default to "origin".David A. Wheeler, Apr 28, 2005
  20. Petr BaudisApr 28, 2005
  21. Dan HolmsandApr 28, 2005
  22. David A. WheelerApr 28, 2005
  23. Dan HolmsandApr 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.