Re: I'm missing isofs.h
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Apr 28, 2005, 16:28 UTC
- Message-ID
- <Pine.LNX.4.58.0504280918230.18901@ppc970.osdl.org>
- In-Reply-To
- <7vvf6698zq.fsf@assigned-by-dhcp.cox.net>
On Thu, 28 Apr 2005, Junio C Hamano wrote:
> > Is /dev/null convention OK with you?
Absolutely. In fact, I prefer it, but I end up just using standard "patch -p1" in the end, so..
> Here is an example of diffstat getting confused:
diffstat is _way_ too easily confused by various things. I've seen it claim "no files" just because the diff had some headers that confused it. And yes, you should always tell it to use "-p1" to get the right pathnames, otherwise it does nonsensical things (if all the diffs happen to be in "drivers/usb/" it ends up deciding that that's just a common prefix, and won't actually show it at all).
However, I'm surprised that it's confused by /dev/null. Usually the confusion comes from the stuff _after_ the name (ie adding the "mode" etc is what I'd have expected to confuse it).
One way to un-confuse diffstat is to add the "Index: " line. I'm not actually much of a fan of Index: lines myself, and I'd rather somebody fixed diffstat, but they _do_ work around diffstat problems.
Linus