Re: [StGit PATCH 00/13] Eliminate 'top' and 'bottom' files

From: David Kågedal <davidk@lysator.liu.se>
Date: Sep 16, 2007, 10:25 UTC
Message-ID: <FB41854B-DC41-4E9F-89E3-2300EE616FD4@lysator.liu.se>
In-Reply-To: <20070915234244.GD25507@diana.vm.bytemark.co.uk>

16 sep 2007 kl. 01.42 skrev Karl Hasselström:

Show 8 quoted lines

> On 2007-09-15 00:31:09 +0200, David Kågedal wrote:
>
>> The following series removes the 'bottom' and 'top' files for each
>> patch, and instead uses the commit objects to keep track of the
>> patches.
>
> Wonderful! Does this ensure that there's a bijection between patches
> and commits at _all_ times, or am I missing something?

That's the intention, at least. As far as I could tell, the biject already held, except temporarily in the middle of executing some commands. So I had to refactor them to never create that intermedate state.

Show 10 quoted lines

>> The last two patches do the final cleansing. Obviously, this changes
>> the format, and the format version should be increased and and
>> update function be written. So it's not really ready to go in yet.
>
> It's a trivial format update, though: just delete those two files and
> increase the number from 2 to 3.
>
> Hmm, wait, no. Right. We also have to create commits for those patches
> that don't have exactly one commit object. Not that there'll be many
> of them, but better not make assumptions ...

I haven't seen any such patches, but I haven't tried everything. Neither do the test suite test everything.

-- 
David Kågedal
davidk@lysator.liu.se