git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH 00/13] Eliminate 'top' and 'bottom' files

From
David Kågedal <davidk@lysator.liu.se>
Date
Sep 14, 2007, 22:31 UTC
Message-ID
<20070914222819.7001.55921.stgit@morpheus.local>

The following series removes the 'bottom' and 'top' files for each patch, and instead uses the commit objects to keep track of the patches.

The patches are based on kha/safe 24a81d7a94cd7c9ad2fc741b0179db5b830cce78 and will conflict with the 'conflict' series in at least one place.

The first ten patches are actually only cleanups and refactoring that could go in regardless of the last ones. Some of the changes are not really necessary, but I did them while digging into the the code, and believe they are improvements. They should not change the way stg behaves in any way.

The eleventh one is just a sanity check before applying the last two that removes the top and bottom files.

The last two patches do the final cleansing. Obviously, this changes the format, and the format version should be increased and and update function be written. So it's not really ready to go in yet.

Also, there are some documentation changes not included in this.

Maybe I should have sent the first ten patches separately, but this makes it clearer why I did it.

---
David Kågedal (13):
      Remove the 'top' field
      Remove the 'bottom' field
      Check bottom and invariants
      Refactor Series.new_patch
      Clear up the semantics of Series.new_patch
      Add a 'bottom' parameter to Series.refresh_patch and use it
      Clean up Series.refresh_patch
      Refactor Series.push_patch
      Remove dead code from push_empty_patch
      Split Series.push_patch in two
      Moved that status function to the status command file
      Clear up semantics of tree_status
      Add some more tests of "stg status" output
 stgit/commands/common.py   |    2 
 stgit/commands/status.py   |   42 +++++++++-
 stgit/commands/sync.py     |    1 
 stgit/commands/uncommit.py |    1 
 stgit/git.py               |   61 +++-----------
 stgit/stack.py             |  189 ++++++++++++++++++++++----------------------
 t/t0002-status.sh          |   36 ++++++++
 7 files changed, 185 insertions(+), 147 deletions(-)
-- 
Signature
Next: David Kågedal
Message 1 of 30 in “Eliminate 'top' and 'bottom' files”
  1. 00/13 Eliminate 'top' and 'bottom' filesDavid Kågedal, Sep 14, 2007
  2. 01/13 Add some more tests of "stg status" outputDavid Kågedal, Sep 14, 2007
  3. 02/13 Clear up semantics of tree_statusDavid Kågedal, Sep 14, 2007
  4. 03/13 Moved that status function to the status command fileDavid Kågedal, Sep 14, 2007
  5. David KågedalSep 14, 2007
  6. 04/13 Split Series.push_patch in twoDavid Kågedal, Sep 14, 2007
  7. 05/13 Remove dead code from push_empty_patchDavid Kågedal, Sep 14, 2007
  8. 06/13 Refactor Series.push_patchDavid Kågedal, Sep 14, 2007
  9. 07/13 Clean up Series.refresh_patchDavid Kågedal, Sep 14, 2007
  10. 08/13 Add a 'bottom' parameter to Series.refresh_patch and use itDavid Kågedal, Sep 14, 2007
  11. 09/13 Clear up the semantics of Series.new_patchDavid Kågedal, Sep 14, 2007
  12. Catalin MarinasOct 8, 2007
  13. Karl HasselströmOct 8, 2007
  14. Catalin MarinasOct 9, 2007
  15. David KågedalOct 10, 2007
  16. Catalin MarinasOct 11, 2007
  17. Karl HasselströmOct 10, 2007
  18. Karl HasselströmOct 10, 2007
  19. 10/13 Refactor Series.new_patchDavid Kågedal, Sep 14, 2007
  20. 11/13 Check bottom and invariantsDavid Kågedal, Sep 14, 2007
  21. 12/13 Remove the 'bottom' fieldDavid Kågedal, Sep 14, 2007
  22. 13/13 Remove the 'top' fieldDavid Kågedal, Sep 14, 2007
  23. Karl HasselströmSep 15, 2007
  24. David KågedalSep 16, 2007
  25. Karl HasselströmSep 17, 2007
  26. Karl HasselströmSep 15, 2007
  27. Catalin MarinasSep 16, 2007
  28. David KågedalSep 16, 2007
  29. Karl HasselströmSep 17, 2007
  30. David KågedalSep 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.