Re: [StGit PATCH 13/13] Remove the 'top' field

From: David Kågedal <davidk@lysator.liu.se>
Date: Sep 16, 2007, 10:22 UTC
Message-ID: <CD668999-4CD3-416C-9205-CEB46FFA2398@lysator.liu.se>
In-Reply-To: <20070915233632.GC25507@diana.vm.bytemark.co.uk>

16 sep 2007 kl. 01.36 skrev Karl Hasselström:

Show 20 quoted lines

> On 2007-09-15 00:32:15 +0200, David Kågedal wrote:
>
>> @@ -436,7 +422,13 @@ class Series(PatchSet):
>>                  patch = patch.strip()
>>                  os.rename(os.path.join(branch_dir, patch),
>>                            os.path.join(patch_dir, patch))
>> -                Patch(patch, patch_dir, refs_base).update_top_ref()
>> +                topfield = os.path.join(patch_dir, patch, 'top')
>> +                if os.path.isfile(topfield):
>> +                    top = read_string(topfield, False)
>> +                else:
>> +                    top = None
>> +                if top:
>> +                    git.set_ref(refs_base + '/' + patch, top)
>>              set_format_version(1)
>>
>>          # Update 1 -> 2.
>
> And remove the top file, maybe? (Or I may be mistaken; I don't have a
> copy of the surrounding code handy.)

No, this is the code that updates from version 0 to version 1. The problem was that the update functionality used the update_top_ref() function in the Patch class which I changed. So I had to inline the code instead.

-- 
David Kågedal
davidk@lysator.liu.se