git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] hook: provide GIT_HOOK for all hooks

From
John Cai <johncai86@gmail.com>
Date
May 31, 2022, 01:31 UTC
Message-ID
<FB3E687E-C381-4C9E-A1B4-13CBE3A48B7A@gmail.com>
In-Reply-To
<xmqqr14dzi2o.fsf@gitster.g>
On 28 May 2022, at 13:24, Junio C Hamano wrote:
Show 9 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> But the commit message & documentation here really should be updated to
>> reflect that this is currently superfluous to inspecting argv in the
>> hook process, and that we're providing this anyway for XYZ reason.
>
> Or this probably is better added as part of the series that actually
> adds the mechanism to trigger hooks defined in the configuration
> file.

I don't mind including this as part of Ævar's config hook series. On the other hand this patch could allow the config hooks series to be smaller and more easily reviewed.

I'm okay either way--maybe Ævar can speak to what his preference is.
Show 5 quoted lines
>
> Then "we do not need it now, but we will in the future because we
> will do XYZ" does not have to be said, which is a huge plus.
>
> Thanks.

thanks John

Previous: Junio C Hamano
Message 7 of 7 in “hook: provide GIT_HOOK for all hooks”
  1. hook: provide GIT_HOOK for all hooksJohn Cai via GitGitGadget, May 27, 2022
  2. Junio C HamanoMay 27, 2022
  3. John CaiMay 28, 2022
  4. Ævar Arnfjörð BjarmasonMay 28, 2022
  5. John CaiMay 28, 2022
  6. Junio C HamanoMay 28, 2022
  7. John CaiMay 31, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.