Re: [PATCH] hook: provide GIT_HOOK for all hooks

From: John Cai <johncai86@gmail.com>
Date: May 28, 2022, 16:42 UTC
Message-ID: <4B161C12-4D12-4403-9C92-1A969A859E8F@gmail.com>
In-Reply-To: <220528.86bkvh3b3q.gmgdl@evledraar.gmail.com>

Hi Ævar

On 28 May 2022, at 11:53, Ævar Arnfjörð Bjarmason wrote:

Show 14 quoted lines

> On Fri, May 27 2022, John Cai via GitGitGadget wrote:
>
>> From: John Cai <johncai86@gmail.com>
>>
>> In order to allow users to use one executable for multiple hooks,
>> provide a GIT_HOOK variable that is set to the hook event that triggered
>> it.
>
> You can use one executable for multiple hooks already, I've written such
> dispatchers that just look at the argv of the process.
>
> What we will need something like this for is for the config-based hooks,
> and I think it makes sense to have a facility that's portable across
> both methods of hook invocations.

Ah yes, thanks for pointing this out. I will re-roll the commit message as we as clarity the documentation.

Show 7 quoted lines

>
> I really don't mind this change, and I think it's a good one to
> make.
>
> But the commit message & documentation here really should be updated to
> reflect that this is currently superfluous to inspecting argv in the
> hook process, and that we're providing this anyway for XYZ reason.