Re: [PATCH] hook: provide GIT_HOOK for all hooks
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 28, 2022, 15:53 UTC
- Message-ID
- <220528.86bkvh3b3q.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <pull.1271.git.git.1653684771998.gitgitgadget@gmail.com>
On Fri, May 27 2022, John Cai via GitGitGadget wrote:
Show 5 quoted lines
> From: John Cai <johncai86@gmail.com> > > In order to allow users to use one executable for multiple hooks, > provide a GIT_HOOK variable that is set to the hook event that triggered > it.
You can use one executable for multiple hooks already, I've written such dispatchers that just look at the argv of the process.
What we will need something like this for is for the config-based hooks, and I think it makes sense to have a facility that's portable across both methods of hook invocations.
I really don't mind this change, and I think it's a good one to make.
But the commit message & documentation here really should be updated to reflect that this is currently superfluous to inspecting argv in the hook process, and that we're providing this anyway for XYZ reason.