Re: [PATCH] Fix and improve t7004
On Nov 16, 2007, at 10:11 PM, Mike Hommey wrote:
Show 14 quoted lines
> On Fri, Nov 16, 2007 at 10:04:57PM +0100, Benoit Sigoure wrote:
>> On Nov 16, 2007, at 9:28 PM, Mike Hommey wrote:
>>> test_expect_success \
>>> 'message in editor has initial comment' '
>>> GIT_EDITOR=cat git tag -a initial-comment > actual || true &&
>>> - test $(sed -n "/^\(#\|\$\)/p" actual | wc -l) -gt 0
>>> + ( read empty ;
>>> + [ "$empty" ] && exit 1 ;
>>
>> What is this meant to do? Did you mean [ -n "$empty" ] ?
>
> Replacing with [ -n "$empty" ] would not work properly, except if you
> replace the following ; with &&. Does that really make a readability
> difference ?
I don't get it. As far as I understand, you're trying to check
whether $empty is indeed empty, right? So how is `[ "$empty" ]'
meant to work?
[ -n "$empty" ] && exit 1
will exit 1 if empty isn't empty.
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
Benoit Sigoure <tsuna@lrde.epita.fr>