Re: [PATCH] Fix t7004 which fails with retarded sed

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 16, 2007, 19:36 UTC
Message-ID: <7vlk8yx9rp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071116191715.GB7624@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 17 quoted lines

>> So the earlier part of the test
>> 
>> 	GIT_EDITOR=cat git tag -a initial-comment > actual || true &&
>> 
>> is already bogus with respect to the latter point.  It will
>> happily continue if "git tag" erroneously returns success, and
>> the above does not catch it.
>> 
>> 	if GIT_EDITOR=cat git tag -a initial-comment >actual
>>         then
>>         	echo >&2 oops we should have errored out
>>                 false
>> 	else
>>         	: happy -- anything else we want to check?
>> 	fi
>
> This should probably be tested in another test block.

Fair enough; please make it so.

> Which is roughly what my patch does, except it doesn't check for
> ordering.

... which I think is more important part. If the blank like were at the end, that would be irritating for the user, wouldn't it?