Re: [PATCH] attr: support quoting pathname patterns in C style
- From
Kevin Ballard <kevin@sb.org>
- Date
- Nov 9, 2010, 08:08 UTC
- Message-ID
- <E3AD4043-4453-494C-A8B8-DD8A8842D2AC@sb.org>
- In-Reply-To
- <4CD8FCC0.2030500@viscovery.net>
On Nov 8, 2010, at 11:48 PM, Johannes Sixt wrote:
Show 19 quoted lines
> Am 11/8/2010 22:56, schrieb Kevin Ballard: >> Basically what I'm trying to say is, we already break one particular >> "rather rare" setup. I would love to come up with a solution that supports >> both setups, but I don't know if one exists outside of using a config >> variable to control whether git attribute patterns support quoting (a solution >> I am not particularly fond of for this case). > > Can we perhaps have a pseudo-attribute 'quoted-names' that is to be used > like this: > > * quoted-names > "file 1" binary > file.1 -diff > > Its meaning would be that the remainder of the current .gitattributes file > is to be parsed with C style path quoting enabled. The glob given with > this attribute is irrelevant and ignored. > > I didn't check whether old gits would ignore this unknown attribute.
This would certainly solve the regression issue, but from the perspective of a brand new user of git this would make absolutely no sense and would be a huge wart upon consistency.
-Kevin Ballard