Re: [PATCH] attr: support quoting pathname patterns in C style

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 5, 2010, 02:02 UTC
Message-ID: <AANLkTimbou_seZnNu9W3akT7SabxSQ7pEJBifjH3UY1r@mail.gmail.com>
In-Reply-To: <4CD33968.4060704@gmail.com>

2010/11/5 Eric Sunshine <ericsunshine@gmail.com>:

Show 21 quoted lines

> On 11/4/2010 9:55 AM, Nguyễn Thái Ngọc Duy wrote:
>>
>> Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
>> 'pat"t"ern', not 'pattern'. Also clarify that leading whitespaces are
>> not part of the pattern and document comment syntax.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy<pclouds@gmail.com>
>> diff --git a/attr.c b/attr.c
>> index 6aff695..f3063d8 100644
>> --- a/attr.c
>> +++ b/attr.c
>>        name = cp;
>> -       namelen = strcspn(name, blank);
>> +       if (*cp == '"') {
>> +               if (unquote_c_style(&pattern, name,&ep))
>> +                       die("Broken attribute line: %s", line);
>
> The error message is perhaps a bit too generic, indicating only that
> _something_ on the line caused a problem. Mentioning that bad quoting of
> 'name' was at fault would help focus the user's attention where it is
> needed.

Really.

-- 
Duy