Re: [PATCH] attr: support quoting pathname patterns in C style

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2010, 16:58 UTC
Message-ID: <7vvd4bu2pl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1288878944-14066-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 8 quoted lines

> Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
> 'pat"t"ern', not 'pattern'. Also clarify that leading whitespaces are
> not part of the pattern and document comment syntax.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Obvious regression: patterns that begin with double quote will
>  now work differently.

I'm really hesitant to pursue this route and break people's existing setups, especially if the only benefit this patch tries to achieve is to allow somebody to say:

    "Program Files/*.txt" ...some attr...

It is not worth the effort, risk and headache, especially because people with such paths are probably already using

    Program?Files/*.txt	...some attr..

to match them.