git/list[1] front-page[2] threads[3] people[4] search[5] about
 

(unknown)

From
Aandyparkins@gmail.com <andyparkins@gmail.com>
Date
Oct 25, 2006, 14:49 UTC
Message-ID
<E1Gck4m-0003J1-00@dvr.360vision.com>
From b149c0fca7399030225750958bf5c962c3796b44 Mon Sep 17 00:00:00 2001
From: Andy Parkins <andyparkins@gmail.com>
Date: Wed, 25 Oct 2006 15:49:50 +0100
Subject: [PATCH] Make new builtin cherry match documentation for "+" and "-"
To: git@vger.kernel.org
X-TUID: 218b478df3f8d847
X-UID: 128
X-Length: 1090
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200610251549.51121.andyparkins@gmail.com>
"+" and "-" don't match the documentation, where "+" means the patch /is/ in
upstream, "-" means it isn't
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 builtin-log.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 840c742..8ded627 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -519,12 +519,12 @@ int cmd_cherry(int argc, const char **ar
 
 	while (list) {
 		unsigned char sha1[20];
-		char sign = '+';
+		char sign = '-';
 
 		commit = list->item;
 		if (!get_patch_id(commit, &patch_id_opts, sha1) &&
 		    lookup_object(sha1))
-			sign = '-';
+			sign = '+';
 
 		if (verbose) {
 			static char buf[16384];
-- 
1.4.2.3
Next: Junio C Hamano
Message 1 of 4 in “(unknown)”
  1. andyparkins@gmail.comOct 25, 2006
  2. Junio C HamanoOct 25, 2006
  3. Andy ParkinsOct 26, 2006
  4. Junio C HamanoOct 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.