Re: Make new builtin cherry match documentation for "+" and "-"

From: Junio C Hamano <junkio@cox.net>
Date: Oct 26, 2006, 08:22 UTC
Message-ID: <7vd58fqyfi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200610260845.23850.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 13 quoted lines

> On Wednesday 2006 October 25 19:41, Junio C Hamano wrote:
>
>> > "+" and "-" don't match the documentation, where "+" means the patch /is/
>> > in upstream, "-" means it isn't
>>
>> The documentation was utterly wrong.  The comment at the
>> beginning of git-cherry.sh was better but slightly wrong.
>
> Seriously?  In git-cherry output a "-" means that a patch is in?  Seems 
> counter-intuitive to me.
>
> Or is it meant to be analogous to a diff so "+" means "in order to make this 
> branch like the comparison branch you would have to /add/ this patch"?

It's more like "This is still relevant and you need to positively push your upstream for inclusion".