Re: (unknown)

From: Junio C Hamano <junkio@cox.net>
Date: Oct 25, 2006, 18:41 UTC
Message-ID: <7vk62ob5mp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <E1Gck4m-0003J1-00@dvr.360vision.com>

andyparkins@gmail.com writes:

Show 12 quoted lines

> From b149c0fca7399030225750958bf5c962c3796b44 Mon Sep 17 00:00:00 2001
> From: Andy Parkins <andyparkins@gmail.com>
> Date: Wed, 25 Oct 2006 15:49:50 +0100
> Subject: [PATCH] Make new builtin cherry match documentation for "+" and "-"
> To: git@vger.kernel.org
> X-TUID: 218b478df3f8d847
> X-UID: 128
> X-Length: 1090
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
> Message-Id: <200610251549.51121.andyparkins@gmail.com>

I'd be commenting on your patch but won't be able to take any of them until these "Subject: (unknown)" are corrected.

> "+" and "-" don't match the documentation, where "+" means the patch /is/ in
> upstream, "-" means it isn't

The documentation was utterly wrong. The comment at the beginning of git-cherry.sh was better but slightly wrong.

I have a few fixes queued but I was busy for the last couple of nights and haven't pushed them out.