Re: [PATCH] bash-completions: add --[no-]graph-indent
- From
Ben Knoble <ben.knoble@gmail.com>
- Date
- Oct 29, 2026, 14:17 UTC
- Message-ID
- <E1710743-1244-4959-81AC-DAA4DFE4B702@gmail.com>
- In-Reply-To
- <DMHD8RCO7V74.2BK7C9T4HNLHO@gmail.com>
Show 28 quoted lines
> Le 29 oct. 2026 à 09:54, Pablo Sabater <pabloosabaterr@gmail.com> a écrit : > > [Cc'd Toon because of the mention] > >> On Tue Oct 13, 2026 at 8:50 PM WEST, Mirko Faina wrote: >> Add missing completion for "git log --graph-indent" and "git log >> --no-graph-indent". >> >> Signed-off-by: Mirko Faina <mroik@delayed.space> >> --- >> contrib/completion/git-completion.bash | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash >> index c3a49e2e22..2348a3cfb9 100644 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -2298,6 +2298,7 @@ __git_log_common_options=" >> --right-only --show-linear-break >> --show-notes-by-default --show-pulls >> --since-as-filter --single-worktree >> + --graph-indent --no-graph-indent > > Thanks for Cc'ing. > > I didn't know about this so I completely forgot to add it, however from > what I read, this is the __git_log_common_options and I'm not sure if > this is a "common" opt, as I don't even see --graph here.
From memory, I think « common » means « useful for multiple completions » (common to multiple commands), not « commonly typed »?
Show 30 quoted lines
> I searched where --graph is, and it's here: > > l 2383-2409 'git-completion.bash' > > __gitcomp " > [more opts] > --graph > [more opts] > $merge > $__git_diff_common_options > " > return > ;; > > I think it would fit better here (not sure, I just quickly skimmed the > file). > > Also, I missed this for the --graph-lane-limit option so maybe it should > be added too? > > My main doubt is, both these options proposed (yours and > --graph-lane-limit) are --graph dependent, which means if someone > autocompletes them but doesn't use --graph, they will get an error > saying that --graph is needed. I'd say we do what other --graph > dependent options do, but AFAIK these two are the only ones. > > From Toon's Git Merge talk, more options for --graph option will be > developed so we should maybe think about how to do it in a way that > doesn't autocomplete if it's going to error? (maybe that does exist, > given the multiple options that depend on other options)
Sounds reasonable, though I also wonder if these commands could eventually be taught to give their own completion help like all the parseopt users.