git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash-completions: add --[no-]graph-indent

From
Toon Claes <toon@iotcl.com>
Date
Nov 9, 2026, 15:40 UTC
Message-ID
<87zevixbbo.fsf@dev.null.iotcl.com.invalid>
In-Reply-To
<aujlNwM6X3BLz22V@exploit>
Mirko Faina <mroik@delayed.space> writes:
Show 54 quoted lines
> On Thu, Oct 29, 2026 at 01:45:15PM +0000, Pablo Sabater wrote:
>> I didn't know about this so I completely forgot to add it, however from
>> what I read, this is the __git_log_common_options and I'm not sure if
>> this is a "common" opt, as I don't even see --graph here.
>> 
>> I searched where --graph is, and it's here:
>> 
>> l 2383-2409 'git-completion.bash'
>> 
>> 	__gitcomp "
>> [more opts]
>> 		--graph
>> [more opts]
>> 		$merge
>> 		$__git_diff_common_options
>> 		"
>> 	return
>> 	;;
>> 
>> I think it would fit better here (not sure, I just quickly skimmed the
>> file).
>
> Yes, you're right. I was on automatic mode when choosing where to place
> it and defaulted to the place where I put an option of mine that worked
> for log. Since this is specific to "git log" I'll place it where you
> suggested.
>
>> Also, I missed this for the --graph-lane-limit option so maybe it should
>> be added too?
>
> Not familiar with the option but will look into it, might as well add
> it.
>
>> My main doubt is, both these options proposed (yours and
>> --graph-lane-limit) are --graph dependent, which means if someone
>> autocompletes them but doesn't use --graph, they will get an error
>> saying that --graph is needed. I'd say we do what other --graph
>> dependent options do, but AFAIK these two are the only ones.
>> 
>> From Toon's Git Merge talk, more options for --graph option will be
>> developed so we should maybe think about how to do it in a way that 
>> doesn't autocomplete if it's going to error? (maybe that does exist,
>> given the multiple options that depend on other options)
>
> From what I can tell the only reason we options through bash-completions
> is because these options are not handled by the parse-options.h
> machinery. Ideally we'd want to port these options to that? I'm assuming
> the reason it wasn't was because of the common options.
>
> With the parse-options.h machinery you can't tell which option depends
> on which other, so it just shows every option available for a command
> when autocompleting. I'm not sure it's worth it to implement such a
> feature with bash-completions when the parse-options.h machinery
> doesn't.

Yes, I agree. It would be cool if parse-options.h would be smarter in this regard, but for now that's not the case, and I'm fine with that. I'm pretty sure (although I cannot think of any right now) there are other options (for other commands) that only work if combined.

I appreciate thinking about this, but that's something for the future.
> Thank you for the review, will reroll.
> Mirko Faina
-- 
Laters,
Toon
Previous: Mirko FainaNext: Mirko Faina
Message 6 of 9 in “bash-completions: add --[no-]graph-indent”
  1. bash-completions: add --[no-]graph-indentMirko Faina, Oct 13, 2026
  2. Mirko FainaOct 29, 2026
  3. Pablo SabaterOct 29, 2026
  4. Ben KnobleOct 29, 2026
  5. Mirko FainaNov 2, 2026
  6. Toon ClaesNov 9, 2026
  7. completions: add some missing options for git logMirko Faina, Nov 2, 2026
  8. Toon ClaesNov 9, 2026
  9. Junio C HamanoNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.