Re: [PATCH v2] completions: add some missing options for git log
- From
Toon Claes <toon@iotcl.com>
- Date
- Nov 9, 2026, 15:41 UTC
- Message-ID
- <87wlqmxb9p.fsf@dev.null.iotcl.com.invalid>
- In-Reply-To
- <5735bacbd5c2c48eddafb43f75f7ddcdf402ff17.1793656021.git.mroik@delayed.space>
Mirko Faina <mroik@delayed.space> writes:
Show 31 quoted lines
> Some options for "git log" are missing in bash-completions, > --graph-lane-limit introduced in [1] and --[no-]graph-indent introduced > in [2]. > > Teach bash-completions to autocomplete these options. > > [1] f756a3c78d (graph: add --graph-lane-limit option, 2026-03-28) > [2] e9b5720bef (graph: add --[no-]graph-indent and log.graphIndent, 2026-07-14) > > Signed-off-by: Mirko Faina <mroik@delayed.space> > --- > contrib/completion/git-completion.bash | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index c3a49e2e22..eab6309a69 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -2395,6 +2395,8 @@ __git_complete_log_opts () > --cherry-mark > --cherry-pick > --graph > + --graph-indent --no-graph-indent > + --graph-lane-limit= > --decorate --decorate= --no-decorate > --walk-reflogs > --no-walk --no-walk= --do-walk > > base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd > -- > 2.56.0
I'm fine with these changes, they do what we want them to. Looks good to me.
-- Laters, Toon