git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 1/1] repo: add filtering options to "repo structure"

From
MCMark C. Chu-Carroll <markchucarroll@fastmail.com>
Date
Nov 18, 2026, 19:30 UTC
Message-ID
<DMYL3TCBEMAJ.2MW8J9PLG9ZD@fastmail.com>
In-Reply-To
<xmqq33u5c6z6.fsf@gitster.g>
On Fri Oct 16, 2026 at 11:59 PM EDT, Junio C Hamano wrote:
Show 39 quoted lines
> "Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
>
>>  t/t1901-repo-structure.sh   | 197 ++++++++++++++++++++++++++++++++++++
>
> This test is broken with SHA-256 and in Git 3.0.
>
>> +test_expect_success 'filter by object type' '
>
> This hardcodes many 40 hexdigits constants, like ...
>
>> +	test_when_finished "rm -rf repo" &&
>> +	git init repo &&
>> +	(
>> ...
>> +		objects.blobs.max_size=13
>> +		objects.blobs.max_size_oid=97d808e45116bf02103490294d3d46dad7a2ac62
>
> ... this one, which is very specific to SHA-1.  Existing tests in
> this file (like the one immediately after this one) protects such a
> test with SHA1 prerequisite to avoid breaking in SHA-256
> environment, which is far from ideal but better than leaving it
> broken.  In the longer term, we should strive to get rid of use of
> SHA1 prerequisites, as SHA-256 will be becoming the default in not
> so distant future versions of Git.
>
>>  test_expect_success SHA1 'lines and nul format' '
>>  	test_when_finished "rm -rf repo" &&
>>  	git init repo &&
>
> If you choose to fix them, see recent effort by others for
> inspiration to make sure you can share and reuse most of this test
> between two supported hash functions, e.g. the discussion that lead
> to
>
>   https://lore.kernel.org/git/pull.2252.v4.git.1792012956734.gitgitgadget@gmail.com/
>
> but you may choose to punt and just put your broken test under SHA1
> prerequisite to sweep the breakage under the rug just like other
> existing tests in this file.
Sorry for the delay in responding to this; I missed this message.

I think that the best approach for now is to put this under SHA1, then I'll take on updating all of the tests in this file to get rid ofthe SHA1 prerequisite.

      -Mark
-- 
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
Previous: Junio C HamanoNext: Mark C. Chu-Carroll
Message 31 of 40 in “repo: add filtering options to "repo structure"”
  1. 0/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Sep 24, 2026
  2. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Sep 24, 2026
  3. Patrick SteinhardtSep 30, 2026
  4. Mark C. Chu-CarrollOct 5, 2026
  5. 0/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 5, 2026
  6. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 5, 2026
  7. Patrick SteinhardtOct 6, 2026
  8. Kaartic SivaraamOct 8, 2026
  9. Mark C. Chu-CarrollOct 9, 2026
  10. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 9, 2026
  11. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 9, 2026
  12. Junio C HamanoOct 9, 2026
  13. Mark C. Chu-CarrollOct 10, 2026
  14. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 10, 2026
  15. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 10, 2026
  16. Patrick SteinhardtOct 13, 2026
  17. Mark C. Chu-CarrollOct 13, 2026
  18. Patrick SteinhardtOct 13, 2026
  19. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 13, 2026
  20. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 13, 2026
  21. Patrick SteinhardtOct 14, 2026
  22. Mark C. Chu-CarrollOct 15, 2026
  23. Patrick SteinhardtOct 15, 2026
  24. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  25. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  26. Kristoffer HaugsbakkOct 15, 2026
  27. Mark C. Chu-CarrollOct 15, 2026
  28. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  29. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  30. Junio C HamanoOct 17, 2026
  31. Mark C. Chu-CarrollNov 18, 2026
  32. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  33. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  34. Patrick SteinhardtOct 16, 2026
  35. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 16, 2026
  36. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 16, 2026
  37. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Nov 18, 2026
  38. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Nov 18, 2026
  39. Junio C HamanoNov 18, 2026
  40. Junio C HamanoNov 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.